Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-130160: use .. program:: directive for documenting pdb CLI #130996

Merged
merged 4 commits into from
Mar 9, 2025
Merged

gh-130160: use .. program:: directive for documenting pdb CLI #130996

merged 4 commits into from
Mar 9, 2025

Conversation

donBarbos
Copy link
Contributor

@donBarbos donBarbos commented Mar 9, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Mar 9, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 9, 2025
Open
6 tasks
gaogaotiantian
gaogaotiantian reviewed Mar 9, 2025
View reviewed changes
@donBarbos @gaogaotiantian
Update pdb.rst
a0384db 
Co-authored-by: Tian Gao <[email protected]>
@gaogaotiantian gaogaotiantian merged commit c240c2d into python:main Mar 9, 2025
28 checks passed
@donBarbos
Copy link
Contributor Author

donBarbos commented Mar 9, 2025 •
edited
Loading

@gaogaotiantian thank you for review, but I thought this issue was awaiting backports

@gaogaotiantian gaogaotiantian added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Mar 9, 2025
@miss-islington-app
Copy link

Thanks @donBarbos for the PR, and @gaogaotiantian for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @donBarbos for the PR, and @gaogaotiantian for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 9, 2025
@donBarbos @miss-islington
pythongh-130160: use .. program:: directive for documenting pdb C…
c773bbb 
…LI (pythonGH-130996)

(cherry picked from commit c240c2d)

Co-authored-by: donBarbos <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 9, 2025

GH-131013 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 9, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 9, 2025
@donBarbos @miss-islington
pythongh-130160: use .. program:: directive for documenting pdb C…
9d9f142 
…LI (pythonGH-130996)

(cherry picked from commit c240c2d)

Co-authored-by: donBarbos <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 9, 2025

GH-131014 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 9, 2025
@gaogaotiantian
Copy link
Member

Huh, I did not realize that we are backporting a documentation improvement. However all the other PRs seem to be backported, so I'm fine with it.

@donBarbos
Copy link
Contributor Author

Thanks

gaogaotiantian pushed a commit that referenced this pull request Mar 9, 2025
@miss-islington @donBarbos
[3.13] gh-130160: use .. program:: directive for documenting pdb …
28406cd 
…CLI (GH-130996) (#131014)

gh-130160: use `.. program::` directive for documenting `pdb` CLI (GH-130996)
(cherry picked from commit c240c2d)

Co-authored-by: donBarbos <[email protected]>
gaogaotiantian pushed a commit that referenced this pull request Mar 9, 2025
@miss-islington @donBarbos
[3.12] gh-130160: use .. program:: directive for documenting pdb …
9f7f2c0 
…CLI (GH-130996) (#131013)

gh-130160: use `.. program::` directive for documenting `pdb` CLI (GH-130996)
(cherry picked from commit c240c2d)

Co-authored-by: donBarbos <[email protected]>
@picnixz
Copy link
Member

picnixz commented Mar 9, 2025

Huh, I did not realize that we are backporting a documentation improvement

Usually docs are backported even when manual backports due to missing/new pieces are needed. That's mostly IMO because docs are continously read and need to be as clear and up-to-date as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@gaogaotiantian gaogaotiantian gaogaotiantian approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donBarbos @gaogaotiantian @picnixz